Skip to content

remove unused @embroider/core dependency - #378

Closed
mansona wants to merge 1 commit into
ember-cli-code-coverage:masterfrom
mansona:remove-embroider-core
Closed

mansona wants to merge 1 commit into
ember-cli-code-coverage:masterfrom
mansona:remove-embroider-core

Conversation

@mansona

@mansona mansona commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator

I don't really see where @embroider/core is being used even though it's a dependency of this package πŸ€” I have run the tests after removing the dependency and it seems to work fine πŸŽ‰

I noticed this when I was trying to try out the new unstable release of embroider and pnpm wasn't allowing me to update because it didn't match the version defined in this package. I figured if it's not being used the best solution is to remove it πŸ‘

@mansona

mansona commented Mar 9, 2023

Copy link
Copy Markdown
Collaborator Author

Turns out it's not as simple as that πŸ˜‚ @embroider/core is a peer dependency so I have to try this a different way

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant