Skip to content

Avoid requiring jQuery for sending the coverage report back. - #24

Merged
kategengler merged 1 commit into
ember-cli-code-coverage:masterfrom
rwjblue:avoid-jquery
Aug 8, 2016
Merged

kategengler merged 1 commit into
ember-cli-code-coverage:masterfrom
rwjblue:avoid-jquery

Conversation

@rwjblue

@rwjblue rwjblue commented Aug 3, 2016

Copy link
Copy Markdown
Collaborator

Works the same:

screenshot

And doesn't troll apps running without jQuery (don't ask yet if that is
a thing plz 😉 ).

@rwjblue

rwjblue commented Aug 3, 2016

Copy link
Copy Markdown
Collaborator Author

tests are failing because ember test is timing out, I'm not sure why yet.

When using this npm link'ed into a test ember-cli project it works properly...

@kategengler

Copy link
Copy Markdown
Collaborator

It looks like Phantom isn't happy with this. I have no patience for that so I went ahead and got rid of Phantom from the testem config and added some more output in the case of failure so future failures will be less mysterious (dc9c95f)

Comment thread lib/templates/test-body-footer.html Outdated
element.appendChild(resultsText);
document.body.appendChild(element);

callback();

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was wrapped in an if (callback) before, for the case when it is run at /tests and there is no Testem callback. Not sure how to write a test that could catch that.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gotcha. I will update, but I'm also unsure of how to test that since we can't run ember test...

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I guess so long as it's there...

@kategengler
kategengler merged commit f02b445 into ember-cli-code-coverage:master Aug 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants