Repository navigation
Avoid requiring jQuery for sending the coverage report back. - #24
Conversation
|
tests are failing because When using this |
|
It looks like Phantom isn't happy with this. I have no patience for that so I went ahead and got rid of Phantom from the testem config and added some more output in the case of failure so future failures will be less mysterious (dc9c95f) |
| element.appendChild(resultsText); | ||
| document.body.appendChild(element); | ||
|
|
||
| callback(); |
There was a problem hiding this comment.
This was wrapped in an if (callback) before, for the case when it is run at /tests and there is no Testem callback. Not sure how to write a test that could catch that.
There was a problem hiding this comment.
Gotcha. I will update, but I'm also unsure of how to test that since we can't run ember test...
There was a problem hiding this comment.
Yeah, I guess so long as it's there...
Works the same:
And doesn't troll apps running without jQuery (don't ask yet if that is
a thing plz 😉 ).