Skip to content

Added support for in-repo addons - #107

Closed
fushi wants to merge 2 commits into
ember-cli-code-coverage:masterfrom
fushi:in-repo-addons
Closed

fushi wants to merge 2 commits into
ember-cli-code-coverage:masterfrom
fushi:in-repo-addons

Conversation

@fushi

@fushi fushi commented Apr 10, 2017

Copy link
Copy Markdown

Adds support for in-repo addons/engines, and their 'addon' folder.

@RobbieTheWagner

Copy link
Copy Markdown
Collaborator

@fushi sorry for the long delay in taking a look at this! It seems that the tests are all failing with maximum call stack size exceeded. Any ideas what is going on there or how to fix it?

@RobbieTheWagner RobbieTheWagner mentioned this pull request Sep 30, 2017
@kratiahuja

Copy link
Copy Markdown

@rwwagner90 / @fushi any update on this PR? Would love to see this land soon.

@RobbieTheWagner

Copy link
Copy Markdown
Collaborator

@kratiahuja no updates really. I spoke to @rwjblue about releasing his spike #141 and I think we are in agreement that we should go ahead and get a basic version of it in, and then add back features as we go. I'll likely merge that and work on it some this weekend, but no guarantees it'll fix this issue. Might be awhile before we can bolt everything back on.

@kratiahuja

Copy link
Copy Markdown

@rwwagner90 any update on getting code coverage working for in-repo addons?

@RobbieTheWagner

Copy link
Copy Markdown
Collaborator

@kratiahuja still no updates. There are two spikes that we need to get in, and @rwjblue has another idea now too as well, so waiting on a decision before pushing forward.

@RobbieTheWagner

Copy link
Copy Markdown
Collaborator

in-repo addons should be supported as of 1.0.0-beta.2. Please try it out and let us know if you experience any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants