Skip to content

Does not work with CoffeeScript #55

Closed

Description

@luketheobscure

It looks like files compiled from CoffeeScript (using ember-cli-coffeescript) are not included when calculating code coverage. They don't show up on any of the reports.

Activity

  1. luketheobscure commented on Nov 1, 2016

    @luketheobscure
    ContributorAuthor

    I've set up a demo app illustrating this bug: https://github.com/luketheobscure/ember-code-coverage-bug

    I don't have the spare time to try to tackle this myself, but I would be happy to test things out.

  2. kategengler commented on Dec 22, 2016

    @kategengler
    Collaborator

    I wonder if this isn't about coffeescript but is actually another manifestation of this bug #20

    That issue was closed in version 0.3.6, could you see if using a newer version fixes this issue for you?

  3. luketheobscure commented on Dec 22, 2016

    @luketheobscure
    ContributorAuthor

    I updated that demo app to 0.3.9, and it didn't fix the problem.

  4. luketheobscure commented on Jun 7, 2017

    @luketheobscure
    ContributorAuthor

    Updated bug demo to use 0.3.12, still seeing the same issue. I would be happy to throw a little bit of time at this if you have any feedback on where to start.

    Edit: Changing preprocessTree to postprocessTree at least insured that ember-cli-coffeescript was called first, but the files are never passed to CoverageInstrumenter.prototype.processString. Unfortunately I'm completely lost at debugging Broccoli, so that's as far as I got.

  5. turboladen commented on Jun 14, 2017

    @turboladen

    +1

  6. RobbieTheWagner commented on Sep 27, 2017

    @RobbieTheWagner
    Collaborator

    @luketheobscure without knowing the exact issue, I think the before or after of ember-cli-coffeescript needs to be tweaked to allow the addons to run in the proper order https://github.com/kimroen/ember-cli-coffeescript/blob/master/package.json#L74-L81

  7. RobbieTheWagner commented on Feb 13, 2018

    @RobbieTheWagner
    Collaborator

    Is there anyone using CoffeeScript that would like to test this out with the latest 1.0.0-beta.2?

  8. RobbieTheWagner commented on Apr 24, 2018

    @RobbieTheWagner
    Collaborator

    @luketheobscure @turboladen can either of your please test this out with the latest beta, 1.0.0-beta.3?

  9. luketheobscure commented on Apr 24, 2018

    @luketheobscure
    ContributorAuthor

    I'm afraid we migrated all of our projects off of CoffeeScript. https://github.com/decaffeinate/decaffeinate is incredible.

  10. RobbieTheWagner commented on Aug 30, 2018

    @RobbieTheWagner
    Collaborator

    CoffeeScript works now, I've tested it on a project using it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions