Skip to content

Missing coverage information in top-level addons in 0.3.3. #53

Closed

Description

@nfc036

Starting from Version 0.3.3 the parameter name in _filterOutAddonFiles is a function and not the actual name. This issue seems fixed when changing line 255 (function _parentName) from

return this.parent.name;

to

return this.parent.pkg.name;

Activity

  1. nfc036 commented on Oct 10, 2016

    @nfc036
    ContributorAuthor

    ... or

    return this.parent.name();
    

    as in #52

  2. rwjblue commented on Oct 10, 2016

    @rwjblue
    Collaborator

    So the underlying issue is tha this.parent is EITHER the project instance (which has a name function) OR an addon instance (which has name as a string property).

    The current logic seems like it will work properly for nested addons (because parent.name will be a string), but not for top level addons.

  3. changed the title [-]Coverage broken since 0.3.3[/-] [+]Missing coverage information in top-level addons in 0.3.3.[/+] on Oct 10, 2016
  4. rwjblue commented on Oct 10, 2016

    @rwjblue
    Collaborator

    Closed by #52

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions