Skip to content

Add workflow that creates a dist branch #409

Open

Description

@cah-brian-gantzler

Now that this is a V2 addon, you are unable to test unreleased changes in master by including it in an application. Please implement the work flow https://github.com/bgantzler/ember-mirage/blob/main/.github/workflows/push-dist.yml.

With this in place a master-dist branch would be created on this repo to try unreleased changes. Also a master-dist would be created on https://github.com/vstefanovic97/ember-cli-code-coverage/tree/master and we would be able to try out those changes prior to merging them into this repos master

Activity

  1. SergeAstapov commented on Mar 13, 2024

    @SergeAstapov
    Contributor

    super minor clarification: ember-cli-code-coverage is still v1 addon, but was converted to monorepo and that's what prevent from simply pointing to github from package.json

  2. cah-brian-gantzler commented on Mar 14, 2024

    @cah-brian-gantzler
    Author

    My bad, as soon as I saw monorep I assumed V2. But since its V1 that means I can use https://gitpkg.vercel.app/ so I can put the following in my package.json

        "ember-cli-code-coverage": "https://gitpkg.now.sh/vstefanovic97/ember-cli-code-coverage/packages/ember-cli-code-coverage?master",
    

    On testing I found that if I did a test without -s and filtered it so just a few test ran, it did produce coverage. However I was never able to reproduce it. So not adding -s does not seem to work.

    When running test with -s, coverage was produced and it seemed to produce as expected for gjs/gts files. All the lines were marked correctly. All .js files, while having coverage, the marks were still off by one line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions