You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With this in place a master-dist branch would be created on this repo to try unreleased changes. Also a master-dist would be created on https://github.com/vstefanovic97/ember-cli-code-coverage/tree/master and we would be able to try out those changes prior to merging them into this repos master
super minor clarification: ember-cli-code-coverage is still v1 addon, but was converted to monorepo and that's what prevent from simply pointing to github from package.json
My bad, as soon as I saw monorep I assumed V2. But since its V1 that means I can use https://gitpkg.vercel.app/ so I can put the following in my package.json
On testing I found that if I did a test without -s and filtered it so just a few test ran, it did produce coverage. However I was never able to reproduce it. So not adding -s does not seem to work.
When running test with -s, coverage was produced and it seemed to produce as expected for gjs/gts files. All the lines were marked correctly. All .js files, while having coverage, the marks were still off by one line.
Activity
SergeAstapov commentedon Mar 13, 2024
super minor clarification:
ember-cli-code-coverageis still v1 addon, but was converted to monorepo and that's what prevent from simply pointing to github from package.jsoncah-brian-gantzler commentedon Mar 14, 2024
My bad, as soon as I saw monorep I assumed V2. But since its V1 that means I can use https://gitpkg.vercel.app/ so I can put the following in my package.json
On testing I found that if I did a test without
-sand filtered it so just a few test ran, it did produce coverage. However I was never able to reproduce it. So not adding-sdoes not seem to work.When running test with
-s, coverage was produced and it seemed to produce as expected for gjs/gts files. All the lines were marked correctly. All .js files, while having coverage, the marks were still off by one line.