Skip to content

No coverage for app files in in-repo addons with v2 beta #341

Closed

Description

@robinborst95

In our codebase we have in-repo addons where all files are defined in the app directory. With the v1 version this works perfectly, we can see the coverage line by line in Codecov. However, when we try out the v2 beta, all those files are not recognized anymore. The coverage itself does seem to be calculated correctly though (the coverage doesn't change in Codecov), so it seems like the files are just missing in the reports.

When I try moving a component to the addon folder of an in-repo addon and re-export it in app again, then that component does show up as expected. This is also something I have confirmed in the tests for coverage in in-repo addons: all files in these tests are defined in the addon folder, so that explains why the tests haven't failed yet. When I then add a file in app, the tests should fail because the file should be missing from the snapshot, but instead it just passes.

I have a PR with a failing test ready, so I hope that will help confirming the issue and fixing it 🙏

Activity

  1. robinborst95 commented on Jan 19, 2022

    @robinborst95
    ContributorAuthor

    Closing this as it's fixable with modifyAssetLocation now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions