Skip to content

Support for module unification app #197

Closed

Description

@abhilashlr

The current stable 0.4.2 or the beta (6) version do not have support for module unification app layout. However, there is a fix for this in the current stable version:
v0.4.2...abhilashlr:v0.4.2-module-unification

Would like to know what is the plan with respect to this MU support.?

Activity

  1. RobbieTheWagner commented on Sep 21, 2018

    @RobbieTheWagner
    Collaborator

    @abhilashlr we'll need to support it for sure. If you have a solution, please submit a PR 😃

  2. abhilashlr commented on Sep 21, 2018

    @abhilashlr
    Author

    But I am unable to send a PR against the tag, can you please publish the 0.4.2 tag as a branch? I can then send a PR.
    At the moment, there are couple of issues with respect to this diff:

    • the coverage is run for *-test.js files inside the src directory; and
    • the tests are run twice.
  3. RobbieTheWagner commented on Sep 21, 2018

    @RobbieTheWagner
    Collaborator

    @abhilashlr we would want these changes in the new code, not in the 0.4.2 code. Can you make these changes based on the master branch?

  4. abhilashlr commented on Sep 21, 2018

    @abhilashlr
    Author

    Okay. I can try.

  5. abhilashlr commented on Sep 22, 2018

    @abhilashlr
    Author

    @rwwagner90 Can you please review the PR.

  6. RobbieTheWagner commented on May 25, 2020

    @RobbieTheWagner
    Collaborator

    Closing since MU is dead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions