You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I just noticed our coverage has been reporting as 100% 0/0 lines. It appears this all started when our projects upgraded to ember-cli-babel@^7.1.0 from ember-cli-babel@^6.17.0
Activity
RobbieTheWagner commentedon Sep 9, 2018
Hi @scottkidder could you try 1.0.0-beta.5 please?
scottkidder commentedon Sep 11, 2018
Hi @rwwagner90 I have tried 1.0.0-beta.5 and am still seeing the same results.
RobbieTheWagner commentedon Sep 11, 2018
@adamjmcgrath any ideas on this? I don't have a ton of time to investigate this right now.
scottkidder commentedon Sep 12, 2018
@rwwagner90 I made a minimal reproduction repo here
Working until
ember-cli-babelgets upgraded to ^7.1.0adamjmcgrath commentedon Sep 18, 2018
Looks like the coverage
pathproperty has changed from relative to absolute for the instrumented code. When I have a moment I'll take a look.ember-cli-babel: 7.1.1
ember-cli-babel: 6.17.0
adamjmcgrath commentedon Sep 18, 2018
This has been fixed in
babel-plugin-istanbul@5.1.0- it's just not been released yetAs a workaround you can do
npm install babel-plugin-istanbul@nextscottkidder commentedon Sep 21, 2018
I have tried
1.0.0-beta.6in my app and in my reproduction repo as well and I am still seeing the same 0/0.RobbieTheWagner commentedon Sep 21, 2018
@adamjmcgrath do you know why this would still be broken?
adamjmcgrath commentedon Sep 24, 2018
Ah ok, it still looks like an issue with
babel-plugin-istanbul, babel 7 now setsopts.filenameto an absolute path (babel/babel#8044), so it needs to change to a relative (module) path - similar to the fix in https://github.com/babel/ember-cli-babel/pull/234/files#diff-168726dbe96b3ce427e7fedce31bb0bcR26RobbieTheWagner commentedon Sep 24, 2018
@adamjmcgrath is there a way we can support both babel 6 and 7 or are we forced to choose here?
RobbieTheWagner commentedon Sep 25, 2018
@adamjmcgrath @kategengler can/should we be supporting both babel 6 and 7 or should we just support 7+ in 1.0+ of this lib?
adamjmcgrath commentedon Sep 25, 2018
The latest ember-cli blueprints still use babel 6 (https://github.com/ember-cli/ember-cli/blob/v3.5.0-beta.1/blueprints/app/files/package.json#L27) so I think it will be a while before most users are on 7
RobbieTheWagner commentedon Sep 25, 2018
@adamjmcgrath While this is true, we want to make sure we either support both for awhile or cut support for babel 6, I think.