Skip to content

TypeError: Cannot convert undefined or null to object #181

Closed

Description

@ming-codes

https://github.com/kategengler/ember-cli-code-coverage/blob/ca8ffbb9f3f2864e21dc53bfa5241b1ad3941529/lib/attach-middleware.js#L22

Somehow the passed in fileLookup is null.

I did some investigation. include hook is indeed called before serverMiddleware, but the this.fileLookup in serverMiddleware is not the same instance as the one in include.

This is on ember-cli-code-coverage@1.0.0-beta.4

Activity

  1. ming-codes commented on May 21, 2018

    @ming-codes
    ContributorAuthor

    🤔 Even this context is different between included and serverMiddleware hooks.

  2. RobbieTheWagner commented on May 22, 2018

    @RobbieTheWagner
    Collaborator

    @ming-codes do you have a reproduction we could look at? Coverage is working for me.

  3. Gaurav0 commented on Jun 1, 2018

    @Gaurav0
    Contributor

    Just ran into this. It may have to do with in-repo-addons.

    Update: PR incoming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions