You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm having trouble getting coverage in engines to work. This is specific to a private repo, but I've tried running coverage in this repo without success.
Steps to reproduce:
cd test/fixtures/my-app-with-in-repo-engine/
COVERAGE=true ember test
cd ../../..
vim coverage/coverage-summary.json
This will show that there are a total of 0 lines in the report although all of the tests have been run.
Support in-repo engine coverage #86 this asked to allow for coverage of in-repo addons. This led to the above test that did not show coverage of lines in the in-repo addon
As a followup for my specific scenario: my app/ folder and /lib folder (lib contains all my engines) are on the same level. When I move the lib folder into the app folder, coverage works fine
@wojm this seems odd. We have test cases that check that in-repo engines work. Can you share your versions of ember-cli-code-coverage, ember-cli, engines, etc?
fwiw, we were experiencing the same problem - our code coverage did not include anything in the lib directory which was at the same level as the app directory.
For us, simply upgrading from 0.4.2 to v1.0.0-beta.4 fixed the issue without any further configuration needed - we now see files from the lib folder in coverage/index.html.
Activity
RobbieTheWagner commentedon May 9, 2018
@wojm this seems odd. We have test cases that check that in-repo engines work. Can you share your versions of
ember-cli-code-coverage,ember-cli,engines, etc?wojm commentedon May 9, 2018
For my specific application these are the relevant dependencies in package.json (I've removed the ones I'm certain don't affect the issue):
In the above reproduction details, I am working in
ember-cli=code-coveragewith version1.0.0-beta.4and thepackage.jsonis as follows:gar commentedon Sep 4, 2018
fwiw, we were experiencing the same problem - our code coverage did not include anything in the
libdirectory which was at the same level as theappdirectory.For us, simply upgrading from
0.4.2tov1.0.0-beta.4fixed the issue without any further configuration needed - we now see files from thelibfolder incoverage/index.html.RobbieTheWagner commentedon Sep 4, 2018
Yes, updating should fix the issues.