Skip to content

Coverage for in-repo-addons not working #120

Closed

Description

@thiagofesta

You can reproduce the problem using this repo: https://github.com/thiagofesta/test-coverage

$ COVERAGE=true ember test

It gives me this error:

this.parent.name is not a function
TypeError: this.parent.name is not a function
    at Class.module.exports._parentName (/Users/tfesta/Code/test-coverage/node_modules/ember-cli-code-coverage/index.js:244:26)
    at Class.module.exports._getExcludes (/Users/tfesta/Code/test-coverage/node_modules/ember-cli-code-coverage/index.js:216:21)
    at Class.module.exports.preprocessTree (/Users/tfesta/Code/test-coverage/node_modules/ember-cli-code-coverage/index.js:48:21)
    at /Users/tfesta/Code/test-coverage/node_modules/ember-cli/lib/utilities/addon-process-tree.js:6:25
    at Array.reduce (native)
    at addonProcessTree (/Users/tfesta/Code/test-coverage/node_modules/ember-cli/lib/utilities/addon-process-tree.js:4:32)
    at Class._addonPreprocessTree (/Users/tfesta/Code/test-coverage/node_modules/ember-cli/lib/models/addon.js:378:12)
    at Class.processedAddonJsFiles (/Users/tfesta/Code/test-coverage/node_modules/ember-cli/lib/models/addon.js:1133:36)
    at Class.compileAddon (/Users/tfesta/Code/test-coverage/node_modules/ember-cli/lib/models/addon.js:1048:24)
    at Class.treeForAddon (/Users/tfesta/Code/test-coverage/node_modules/ember-cli/lib/models/addon.js:707:26)

I also had another problem earlier, where it complained about isEmberCLIAddon method not defined. What i did, was to create that method on the in repo addon and return false. But by default it is not generated by ember cli, maybe you could assume if it is undefined, use it as false.

Thanks

Activity

  1. rwjblue commented on Jun 14, 2017

    @rwjblue
    Collaborator

    Thank you reporting! I'll try to dig into the demo soon and see how hard it will be to fix...

  2. thiagofesta commented on Jun 23, 2017

    @thiagofesta
    Author

    @rwjblue any update on this one?

  3. GCheung55 commented on Aug 8, 2017

    @GCheung55

    PR #107 tried to address this but there are test errors.

  4. rwjblue commented on Oct 2, 2017

    @rwjblue
    Collaborator

    #141 should make this a bit easier to do, but is still somewhat WIP. I believe that the changes @GCheung55 submitted in #107 will come in handy in that branch...

  5. RobbieTheWagner commented on Feb 2, 2018

    @RobbieTheWagner
    Collaborator

    I believe this works as of the latest beta. Can you guys try it out?
    screen shot 2018-02-02 at 12 21 33 am

  6. RobbieTheWagner commented on Feb 9, 2018

    @RobbieTheWagner
    Collaborator

    Closing this, as it should be fixed in the latest beta. If not, feel free to reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions