Skip to content

Coverage drop in ember-cli 2.12.2 #110

Closed

Description

@denchen

First off, I don't know if this is related to #77 or not. Basically, template files used to be counted, and now they're not.

I was on ember-cli@2.7.3 and just upgraded to 2.12.2. I also went from 0.2.2 of this library to 0.3.12. Afterwards, I saw a sharp drop in coverage. For instance, lines went from 9219/10506 down to 1190/2353. After a cursory bit of digging, I realized it was no longer counting my template files. For instance, in one of my components, previously I had 259/259 lines covered, and now it's 0. And looking at the .hbs in the /coverage/lcov-report/ directory, it's kinda easy to see why. Whereas before, it looked something like this:

screenshot 2017-04-23 17 08 07

Now it looks like this:

screenshot 2017-04-23 17 08 39

Is this due to the new Glimmer engine? Is there some kind of setting I need to get my template files counted again?

Activity

  1. rwjblue commented on Apr 24, 2017

    @rwjblue
    Collaborator

    Yes, its related to updating to ember 2.10+ (the templates used to be JavaScript but now they are JSON). #103 Is attempting to fix this.

  2. denchen commented on Apr 26, 2017

    @denchen
    Author

    Thanks for the response. In your estimation, is adding template instrumentation something that will take days, weeks, or months to accomplish? Or another way of puttng it, how high or low is this on your priority list? Thanks again!

  3. RobbieTheWagner commented on Feb 13, 2018

    @RobbieTheWagner
    Collaborator

    @adamjmcgrath is going to be tackling template instrumentation, so hopefully we'll get this back soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions