fix(templates): stop leaking the template's title into published pages (CoreBunch#217)

hrq-chiuchi · Henrique Chiuchi · web-flow · commit b6fa4084665f · 2026-07-24T00:34:33.000+02:00
composeTemplateChain always returned the innermost TEMPLATE's title as
the merged page's title, never the actual page or entry being
rendered. Every published page's &lt;title&gt; and &lt;head&gt; metadata came from
whichever template wrapped it: ordinary pages all showed the
"everywhere" template's title, and post-type entries showed the
postType template's title instead of the entry's own title.

For a page terminal, terminal.page is already available inside
composeTemplateChain, so use its title directly. For an entry
terminal there is no Page object at that layer, so the two callers
(renderPublishedDataRowTemplate and the row preview handler) set
merged.title from the published/draft row's own title cell right
after composing, before the page is rendered.

Co-authored-by: Henrique Chiuchi &lt;henriquechiuchi@outlook.com&gt;
diff --git a/server/handlers/cms/data/preview.ts b/server/handlers/cms/data/preview.ts
@@ -94,6 +94,9 @@ export async function handleRowPreview(
     return jsonResponse({ error: 'No entry template found for this collection' }, { status: 404 })
   }
   const merged = composeTemplateChain(chain, { kind: 'entry' })
+  // The template chain has no Page for the entry, so composeTemplateChain
+  // can't know its title — the entry's own (draft) title is the real document title.
+  if (typeof draftCells.title === 'string') merged.title = draftCells.title
 
   // Build a synthetic PublishedDataRow with the draft cells merged in.
   // Bindings inside the template (`{currentEntry.body}`, featured-media
diff --git a/server/publish/publicRenderer.ts b/server/publish/publicRenderer.ts
@@ -176,6 +176,9 @@ export async function renderPublishedDataRowTemplate(
   const chain = resolveTemplateChain(snapshot.site, { kind: 'entry', tableSlug: row.tableSlug })
   if (chain.length === 0) return null // no entry template → 404 (unchanged behaviour)
   const merged = composeTemplateChain(chain, { kind: 'entry' })
+  // The template chain has no Page for the entry, so composeTemplateChain
+  // can't know its title — the entry's own title is the real document title.
+  if (typeof row.cells.title === 'string') merged.title = row.cells.title
 
   // Seed the entry stack with the published row + route frame from the request
   // URL. Loop interceptors push/pop iteration items on top of this stack;
diff --git a/src/core/templates/templateCompose.ts b/src/core/templates/templateCompose.ts
@@ -140,7 +140,11 @@ export function composeTemplateChain(chain: Page[], terminal: TerminalContent):
   return {
     id: innermost.id, // identifies "what was rendered" for the publish.html filter
     slug: innermost.slug,
-    title: innermost.title,
+    // The terminal page's own title is the document's real title — the
+    // wrapping template's title is chrome, never `<title>` content. Entry
+    // terminals have no Page here; their caller overrides `title` from the
+    // published row after composing.
+    title: terminal.kind === 'page' ? terminal.page.title : innermost.title,
     rootNodeId: acc.rootId,
     nodes: acc.nodes,
   }

Original file line number	Diff line number	Diff line change
`@@ -94,6 +94,9 @@ export async function handleRowPreview(`
`94`	`94`	`return jsonResponse({ error: 'No entry template found for this collection' }, { status: 404 })`
`95`	`95`	`}`
`96`	`96`	`const merged = composeTemplateChain(chain, { kind: 'entry' })`
	`97`	`+ // The template chain has no Page for the entry, so composeTemplateChain`
	`98`	`+ // can't know its title — the entry's own (draft) title is the real document title.`
	`99`	`+ if (typeof draftCells.title === 'string') merged.title = draftCells.title`
`97`	`100`
`98`	`101`	`// Build a synthetic PublishedDataRow with the draft cells merged in.`
`99`	`102`	// Bindings inside the template (`{currentEntry.body}`, featured-media