Split widget exports from GraphViz draw renderer#45
Merged
Conversation
57fcae1 to
d531752
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #45 +/- ##
============================================
- Coverage 76.17% 74.12% -2.05%
- Complexity 1362 1421 +59
============================================
Files 64 67 +3
Lines 4844 5013 +169
============================================
+ Hits 3690 3716 +26
- Misses 1154 1297 +143 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d531752 to
62d8be7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
svg,png, and Mermaid source/workflow/workflows/draw/{workflow}server-side exports forsvg,png, andmmdsvg/pngvia GraphVizdot, documented as an opt-in dependencyDetails
The widget export path and the canonical draw endpoint had become mixed together.
This splits them cleanly:
WorkflowHelper::widget()now exports:svgfrom the original rendered Mermaid SVGpngfrom a sanitized browser-side rasterization pathmmdfrom the Mermaid source used by the widget/workflow/workflows/draw/{workflow}now serves:mmdfromMermaidRenderersvg/pngfrom a newGraphvizRendererThis keeps the embedded app UX simple while still providing a stable backend export endpoint.
Docs
svg/png/mmdwidget exportsdrawimage exportsVerification
Verified locally against a real app page and live endpoint:
Export SVGrestored to the original rendered Mermaid SVGExport PNGnow produces a non-empty image with crisp current/initial/final labels/workflow/workflows/draw/prototype_domain_onboarding?format=svg...returns real SVG/workflow/workflows/draw/prototype_domain_onboarding?format=png...returns real PNG via GraphVizI also checked the workflow graph on:
https://applicationbrain-cake.ddev.site:33001/onboardings?domain=owamat-separator&id=2