Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add Go module collection support #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Uh oh!
There was an error while loading. Please reload this page.
Add Go module collection support #14
Changes from 1 commit
ab183bbeaf9fc06ea03fa6ce779b2402ad1b6403dcFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
GoDirectory.tests used to spin up a Go container and parse 'go test -list' stdout to enumerate test names. Replace that with a single Workspace.directory(...).search(pattern: "^func Test\\w+\\(") over the directory's *_test.go files and parse names from the matched lines in Dang. This is much faster (no compile, no container exec) and matches the same set go test -list does for top-level test functions. Test methods on testify-style suites are intentionally not listed: they cannot be selected with go test -run independently of their parent function. Add moduleIntrospectionCheck assertions covering the new GoTestDirs and GoTests collection surface end-to-end: keys/get round-trip on both levels, multi-test discovery from a single *_test.go file (cross- include-b has two top-level tests), and that a skip-configured directory produces an empty tests collection. Signed-off-by: Solomon Hykes <solomon@dagger.io>Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing