refactor(mcp): clean up multi-target naming and tests after PR #843#942
Merged
matzew merged 1 commit intoMar 20, 2026
Merged
Conversation
…ners#843 - Rename isMultiCluster to isMultiTarget for consistency with the Provider.IsMultiTarget() interface method - Add godoc to IsMultiTarget() explaining its relationship to GetTargets and intended implementation contract - Remove redundant multicluster-enum testdata and test (enum behavior was removed in containers#843, making it identical to the multicluster test) - Fix TestClusterAwareTool to use mutator return value instead of relying on shared pointer side effects - Remove redundant TestClusterAwareToolMultipleClusters (now identical to TestClusterAwareTool after enum removal) Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
refactor/cleanup-multi-target-naming
branch
from
March 20, 2026 09:00
6e62062 to
a253b07
Compare
matzew
reviewed
Mar 20, 2026
| } | ||
|
|
||
| func ShouldIncludeTargetListTool(targetName string, isMultiCluster bool) ToolFilter { | ||
| func ShouldIncludeTargetListTool(targetName string, isMultiTarget bool) ToolFilter { |
matzew
pushed a commit
to matzew/kubernetes-mcp-server
that referenced
this pull request
Mar 24, 2026
…ners#843 (containers#942) - Rename isMultiCluster to isMultiTarget for consistency with the Provider.IsMultiTarget() interface method - Add godoc to IsMultiTarget() explaining its relationship to GetTargets and intended implementation contract - Remove redundant multicluster-enum testdata and test (enum behavior was removed in containers#843, making it identical to the multicluster test) - Fix TestClusterAwareTool to use mutator return value instead of relying on shared pointer side effects - Remove redundant TestClusterAwareToolMultipleClusters (now identical to TestClusterAwareTool after enum removal) Signed-off-by: Marc Nuri <marc@marcnuri.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up cleanup to #843 addressing naming inconsistencies, missing documentation,
and redundant tests left over from the enum removal.
isMultiClusterparameter toisMultiTargetfor consistency with theProvider.IsMultiTarget()interface methodIsMultiTarget()clarifying its relationship toGetTargetsandintended implementation contract
toolsets-full-tools-multicluster-enum.jsontestdata andTestDefaultToolsetsToolsInMultiClusterEnum(identical to the multicluster testafter enum removal in refactor(kubernetes)!: provider.GetTargets is optionally user scoped now #843)
TestClusterAwareToolto use mutator return value instead of relying onshared pointer side effects
TestClusterAwareToolMultipleClusters(identical toTestClusterAwareToolafter enum removal)