fix(kubevirt): avoid article agreement issue in product name templates#1287
Merged
Cali0707 merged 1 commit intoJul 13, 2026
Merged
Conversation
The vm_clone and vm_create tool descriptions used "a %s VirtualMachine", which reads fine for "a KubeVirt" but breaks for downstream product name overrides starting with a vowel sound (e.g. "an OpenShift Virtualization VirtualMachine"). Rephrase to avoid the leading article before the templated product name. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Karel Simon <ksimon@redhat.com>
Contributor
|
👋 Heads up — this pull request changes files owned by @lyarwood. You are listed as an owner of one or more of the changed areas in |
lyarwood
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The vm_clone and vm_create tool descriptions used "a %s VirtualMachine",
which reads fine for "a KubeVirt" but breaks for downstream product name
overrides starting with a vowel sound (e.g. "an OpenShift Virtualization
VirtualMachine"). Rephrase to avoid the leading article before the
templated product name.
/cc @lyarwood
Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com
Signed-off-by: Karel Simon ksimon@redhat.com