chore(deps): pin gen-crd-api-reference-docs via replace directive#1145
Merged
manusa merged 1 commit intoMay 11, 2026
Merged
Conversation
tektoncd/pipeline v1.12.0 transitively requires gen-crd-api-reference-docs@v0.3.1-0.20260316152250-6bbddc29119c. The referenced commit exists on GitHub but is not reachable from any branch, tag, or PR ref in the upstream repo, so proxy.golang.org and GOPROXY=direct both 404. This breaks `go list -m all` and IDE module indexing (GoLand/IntelliJ flag the whole project as broken), even though `go build` and `go test` are unaffected because nothing in this repo imports the package. Pin the dependency to the tagged v0.3.0 via a `replace` directive so module resolution succeeds. The tool is only used for docs generation upstream and is never compiled into our binary. Tracked upstream at tektoncd/pipeline#9997 — the workaround can be removed once tekton ships a patched release. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Marc Nuri <marc@marcnuri.com>
Member
Author
|
Merging since upstream it was confirmed that this needed fixing. |
This was referenced Jun 29, 2026
manusa
added a commit
to marcnuri-forks/kubernetes-mcp-server
that referenced
this pull request
Jun 29, 2026
The replace directive added in containers#1145 worked around tektoncd/pipeline pinning gen-crd-api-reference-docs to an unreachable commit. But Go rejects `go install <module>/...@latest` (and `go get`) for any module whose go.mod contains replace or exclude directives, so installing the server from source was broken even though `make build` of a clone was fine. tektoncd/pipeline v1.13.1 now requires a fetchable version of that dependency (fixed upstream in tektoncd/pipeline#9999), so the workaround is obsolete. Remove it and add a regression test that fails if a replace or exclude directive is reintroduced into go.mod. Fixes containers#1231 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Marc Nuri <marc@marcnuri.com>
matzew
pushed a commit
that referenced
this pull request
Jun 29, 2026
The replace directive added in #1145 worked around tektoncd/pipeline pinning gen-crd-api-reference-docs to an unreachable commit. But Go rejects `go install <module>/...@latest` (and `go get`) for any module whose go.mod contains replace or exclude directives, so installing the server from source was broken even though `make build` of a clone was fine. tektoncd/pipeline v1.13.1 now requires a fetchable version of that dependency (fixed upstream in tektoncd/pipeline#9999), so the workaround is obsolete. Remove it and add a regression test that fails if a replace or exclude directive is reintroduced into go.mod. Fixes #1231 Signed-off-by: Marc Nuri <marc@marcnuri.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tektoncd/pipeline v1.12.0transitively requiresgen-crd-api-reference-docs@v0.3.1-0.20260316152250-6bbddc29119c. The commit exists on GitHub but is not reachable from any branch, tag, or PR ref in the upstreamahmetb/gen-crd-api-reference-docsrepo, so bothproxy.golang.organdGOPROXY=directreturn 404.This breaks
go list -m alland IDE module indexing (GoLand/IntelliJ flag the entire project as broken).go buildandgo testwere unaffected because nothing in this repo imports the package — it's only used for docs generation in upstream tekton.Fix
Add a
replacedirective pinninggen-crd-api-reference-docsto the taggedv0.3.0so module resolution succeeds. The package isn't compiled into our binary, so the specific version doesn't matter — only that it resolves.The root cause is tracked upstream at tektoncd/pipeline#9997. The
replacecan be removed once tekton ships a patched release.Reproduction
After this change,
go list -m allsucceeds and IDE indexing completes cleanly.Test plan
make tidysucceedsgo list -m allresolves cleanlygo build ./...succeeds