fix(pods): resolve default container for multi-container pods (KEP-2227)#1060
Merged
manusa merged 1 commit intoApr 16, 2026
Merged
Conversation
pods_log fails on multi-container pods when no container parameter is provided because it passes an empty string to the Kubernetes API. pods_exec had a partial fix (falling back to the first container) but did not honor the kubectl.kubernetes.io/default-container annotation. Add a resolveContainer helper implementing the KEP-2227 resolution order: explicit param → single container → annotation → first container. Both PodsLog and PodsExec now use this shared logic. Fixes containers#1000 Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pods_logfails on multi-container pods when no container parameter is provided because it passes an empty string to the Kubernetes API.pods_exechad a partial fix (falling back to the first container) but did not honor thekubectl.kubernetes.io/default-containerannotation.Add a resolveContainer helper implementing the KEP-2227 resolution order:
Both
PodsLogandPodsExecnow use this shared logic.Fixes #1000