refactor(helm): resolve config in constructor following Kiali pattern#1006
Merged
nader-ziada merged 1 commit intoApr 2, 2026
Merged
Conversation
manusa
marked this pull request as ready for review
April 2, 2026 11:05
manusa
marked this pull request as draft
April 2, 2026 11:06
manusa
force-pushed
the
review/helm-add-backend-storage-driver
branch
from
April 2, 2026 11:09
ac02aeb to
2db61ce
Compare
Move Helm config resolution from individual tool handlers into NewHelm, eliminating duplicated boilerplate across helmInstall, helmList, and helmUninstall. This aligns with the Kiali toolset pattern where config is resolved once at instantiation time. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
review/helm-add-backend-storage-driver
branch
from
April 2, 2026 11:19
2db61ce to
a690f36
Compare
manusa
marked this pull request as ready for review
April 2, 2026 11:23
Contributor
|
@manusa +1 for this ... I was planning to go this path but didn't wanted to break the interface. This opens up for some more controls over helm via config file that I would like to propose in next few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NewHelmconstructorGetToolsetConfig/type-assertion boilerplate fromhelmInstall,helmList, andhelmUninstall*Configparameter fromInstall,List,Uninstall, andnewActionmethods — config is now read from theHelmstructFollows up on #998.