fix(coderd): require update permission to recreate devcontainers (#25812)#26320
Merged
Conversation
- The httpmw upstream from this endpoint only checks for read perms to the workspace agent. Recreating a dev container should require `update` perms since it mutates state. This also matches the behavior of the `DELETE` endpoint
deansheather
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25812 to
release/2.29(SEC-84 / DEVEX-399).Conflict resolution: 2.29 has no
WorkspaceAgentAndWorkspaceParammiddleware, so the handler authorizes againsthttpmw.WorkspaceParam(r). The authorization test resolves the agent ID via the workspace API sincedbfake.WorkspaceResponsehas noAgentsfield on this branch. Dropped the out-of-scopeTestWorkspaceAgentDeleteDevcontainer(DELETE endpoint does not exist on 2.29).