fix: clamp template port sharing level in SubAgentAPI (#26061)#26318
Merged
Conversation
Fixes an issue where sub-agent apps created via CreateSubAgent would bypass the check for the template's max port sharing level: - Clamps dynamically inserted `workspace_apps` to the template max sharing level in `coderd.agentapi.SubAgentAPI`. - Emits a warning when clamping occurs. - Adds unit test coverage for the max sharing level matrix. - Adds an integration-ish test through the devcontainer sub-agent client path. > 🤖 Generated by Coder Agents with guidance from a human.
deansheather
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #26061 to
release/2.29(SEC-80 / CODAGT-479).Conflict resolution:
CreateSubAgenton this branch predates the terraform-defined devcontainer (req.Id) flow, so only the template fetch and port-share clamp were applied. DroppedBoundaryUsageTracker/LifecycleMetricsoptions that do not exist on 2.29.