fix: reject oversized and invalid zip uploads (#25877)#26272
Merged
Conversation
Enforce aggregate limits when converting uploaded ZIP archives to tar so compressed inputs cannot expand without bound in memory. Also treat malformed ZIP entry metadata and content mismatches as client errors during conversion, returning 400 for invalid archives and 413 when expanded tar output exceeds the upload limit. Ref: https://linear.app/codercom/issue/PLAT-274/zip-upload-decompressed-without-aggregate-size-limit-sec-103 (cherry picked from commit 2f011fd)
f0ssel
approved these changes
Jun 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #25877 to
release/2.29.Cherry-picked with
git cherry-pick -x(2f011fd2a3); the commit message references the original PR.Cherry-pick conflict resolution
The core fix (
archive/archive.go,coderd/files.go) applied cleanly.coderd/files_test.goneeded a small adaptation: this branch predates the shared test-client refactor, so the newbuildZipWithFilehelper was kept and the two new sub-tests create their own client, matching the other sub-tests on this branch.go test ./archive/...passes and thecoderdtest package compiles.Generated by Coder Agents on behalf of @jdomeracki-coder.