Skip to content

fix(coderd/workspaceapps): verify workspace owner matches app username (#26085)#26261

Merged
f0ssel merged 2 commits into
release/2.34from
cherry-pick/26085/release/2.34
Jun 11, 2026
Merged

fix(coderd/workspaceapps): verify workspace owner matches app username (#26085)#26261
f0ssel merged 2 commits into
release/2.34from
cherry-pick/26085/release/2.34

Conversation

@jdomeracki-coder

Copy link
Copy Markdown
Contributor

Cherry-pick backport to release/2.34.

#26085)

fix(coderd/workspaceapps): verify workspace owner matches app username

When resolving a workspace app by workspace UUID, the URL's username
segment was never reconciled against the resolved workspace's owner.
A user could serve their own workspace app from a hostname embedding
another user's username, so the parsed origin username belonged to the
victim.  Combined with the username-equality CORS check, this allowed
credentialed cross-origin reads of the victim's app responses.

Reject the request with a 404 when the resolved workspace's owner does
not match the user named in the request.

Refs: https://linear.app/codercom/issue/PLAT-260
(cherry picked from commit 0b99e67)
@f0ssel f0ssel merged commit 3019613 into release/2.34 Jun 11, 2026
23 checks passed
@f0ssel f0ssel deleted the cherry-pick/26085/release/2.34 branch June 11, 2026 17:59
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants