fix: do not clobber dynamic parameters (backport #24645 to 2.32)#25827
Merged
Conversation
a3e7493 to
58354ca
Compare
Once a user has touched a field, it is better to leave it alone and display explicit validation errors over silently overwriting their inputs. Same for auto-filled values (whether from query parameters or a previous build). (cherry picked from commit d958d89)
58354ca to
e97f74d
Compare
bed151c to
7d94589
Compare
This branch is from before the vitest migration was complete. Also revert the user event changes. Not sure why but with Jest without the waitFor we get a timeout.
7d94589 to
e1620aa
Compare
f0ssel
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #24645 to
release/2.32.Once a user has touched a field, it is better to leave it alone and display explicit validation errors over silently overwriting their inputs. Same for auto-filled values (whether from query parameters or a previous build).
Original PR: #24645 — fix: do not clobber dynamic parameters
Merge commit: d958d89
Closes #23418
Cherry-pick conflict resolution
Two conflicts resolved:
site/src/testHelpers/websockets.ts: File was empty on release/2.32. Took the incoming version with the newmockDynamicParameterWebSockethelper.site/src/pages/CreateWorkspacePage/CreateWorkspacePage.jest.tsx: File is.jest.tsxon the release branch (.test.tsxon main). Applied the incoming content (refactored websocket mocking, modernized test calls) to the existing.jest.tsxfilename.Note
Generated with Coder Agents by @rowansmithau