feat(vpn): add provider selector to VPN quick-toggle#1713
Open
nouredeen06 wants to merge 2 commits into
Open
Conversation
nouredeen06
force-pushed
the
feat/vpn-provider-selector
branch
2 times, most recently
from
July 16, 2026 10:47
73c371a to
b48d4e7
Compare
nouredeen06
marked this pull request as ready for review
July 16, 2026 10:50
dxnnv
suggested changes
Jul 18, 2026
nouredeen06
commented
Jul 18, 2026
nouredeen06
left a comment
Author
There was a problem hiding this comment.
Applied suggestions by @dxnnv
Right-click the VPN quick-toggle to open a menu listing every configured provider and switch the active one. Left-click keeps the existing connect/disconnect behaviour. Uses VPN.providers as the model, VPN.selectedProvider for highlight tracking, and VPN.setActiveProvider() to switch providers.
nouredeen06
force-pushed
the
feat/vpn-provider-selector
branch
from
July 18, 2026 16:09
473695e to
3055450
Compare
dxnnv
approved these changes
Jul 18, 2026
dxnnv
left a comment
Contributor
There was a problem hiding this comment.
Tested this locally, seems to work fine. VPN switching functions as expected and didn't encounter any errors.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right-click the VPN quick-toggle to open a menu listing every configured provider and switch the active one. Left-click keeps the existing connect/disconnect behaviour.
Adds VPN.selectProvider(index), which disconnects the current provider (if connected) and reassigns the provider array so only the chosen index is enabled.