Add type annotations to a few files#904
Closed
qwergle wants to merge 2 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #904 +/- ##
==========================================
- Coverage 67.92% 67.92% -0.01%
==========================================
Files 61 61
Lines 9147 9150 +3
==========================================
+ Hits 6213 6215 +2
- Misses 2934 2935 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sebastinas
requested changes
Aug 11, 2021
sebastinas
left a comment
Contributor
There was a problem hiding this comment.
Please also run black to ensure consistent formatting after your changes.
Contributor
Author
|
The commit I just added performs all of the changes you requested, as well as reformatting many files using black. |
Contributor
|
hmm, I had to rerun black again. Merged after doing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR just adds some type annotations to a few files, and is meant to help with fixing #892. It's not much, but I'm still working on adding type annotations to all files.