Upgrade to Django 4.2#3341
Merged
Merged
Conversation
6726b1e to
a3430c9
Compare
Author
|
Rebased on #3350 to allow defining |
a6159b3 to
68b1994
Compare
Accessing many-to-many relations before saving is no longer allowed. Reorder all operations consistently: 1. Validations 2. Modify own fields 3. Perform save by calling super().save() 4. Modify related objects and clear caches Especially clearing caches should be done after actually saving, otherwise the old data can be re-added immediately by another request before the new data is written.
The problem that boto3 closes files has been worked around in django-storages.
Author
|
@bookwyrm-social/code-review This PR is ready for review |
dato
approved these changes
May 22, 2024
minor contributions to django 4.2 upgrade
Co-authored-by: Adeodato Simó <73768+dato@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
USE_L10NsettingpytztozoneinfoCSRF_TRUSTED_ORIGINSare neededsave()methods due to changes in releations for unsaved model instancesSTORAGESsettingheaderskwarg for test HTTP clientupdate_fieldsin overriddensave()when extra fields are modified may now be requiredCICharFieldwith custom case-insensitive collationrequirements.txtand change to>=(for security fixes)Other points of note: