Skip to content

nodejs v4.2.x compatibility #110

Open

Description

@rimmartin

Hi,
Anybody running successfully with nodejs v4.2.x?

            var buffers = [];
            stream.on('data', function(buffer) {
          console.dir("streaming data "+buffer.constructor.name);
              buffers.push(buffer);
            });

is saying the buffer arg is a String and not a Buffer yet the original documentation says it should be a Buffer https://github.com/binaryjs/binaryjs/blob/master/doc/api.md

Buffer has been completely rewritten to be based on Uint8Array

Activity

  1. rimmartin commented on Oct 25, 2015

    @rimmartin
    Author

    a github clone's tests run with v4.2.1 and mocha 2.3.3. console.dir gives constructor name Buffer and Buffer.isBuffer returns true.

    My case the stream is from a browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions