Repository navigation
fix(cli): report an unknown project as not found in reindex - #2053
Merged
Merged
Conversation
reindex -p and project index asked get_project_mode() about a name that matched no local project. That method treats every name missing from config as CLOUD, so a typo was reported as a cloud project and the not-found branch was unreachable. Only a config entry marked cloud is a cloud project now; anything else is not found, with the local project names listed. Fixes #2029 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMYVL4TcbWdXhdvAzxfqjo Signed-off-by: phernandez <paul@basicmachines.co>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2029.
bm reindex -p <name>andbm project index <name>reported a mistyped name as "is a cloud project". When no local project matched, the code askedget_project_mode(), which treats every name missing from config as CLOUD. The not-found branch was unreachable for a typo.Now only a config entry marked cloud gets the cloud message. Any other name gets:
The exit code is still 1 in both cases.
Tests in
tests/cli/test_db_reindex.pyuse a real config and database, with no monkeypatching:test_reindex_reports_an_unknown_project_as_not_foundfails on main and passes here.test_reindex_still_refuses_a_configured_cloud_projectkeeps the cloud message for a configured cloud project.#1809 is the MCP side of the same kind of message and is not covered here.
π€ Generated with Claude Code
https://claude.ai/code/session_01CMYVL4TcbWdXhdvAzxfqjo