Repository navigation
test(ci): fix Windows decoding and line endings in four tests - #2050
Merged
Merged
Conversation
On Windows, subprocess text=True decodes the child's UTF-8 output with the cp1252 locale codec, so the reader thread fails and stdout is None. Decode as UTF-8 in test_cli_exit, test_fresh_install and test_chatgpt_graphs. The skill resource test compared served text to read_text(), which turns a CRLF checkout into LF. Compare to the decoded bytes instead. Raise the ChatGPT import hang guard from 15s to 60s; a loaded Windows runner timed out during startup and migrations. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CMYVL4TcbWdXhdvAzxfqjo Signed-off-by: phernandez <paul@basicmachines.co>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
βΉοΈ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with π while any review is running, comments if it has suggestions, and reacts with π once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main's
test.ymlfails on the Windows SQLite unit shards (runs 41866893188, 41853960947, 41795319355), so Coverage is skipped.test_cli_exit.py,test_fresh_install.py,test_chatgpt_graphs.py:text=Truedecodes the child's UTF-8 output with cp1252 on Windows. The reader thread raisesUnicodeDecodeErrorandstdoutisNone. Passencoding="utf-8".test_skill_resources.py(from feat(mcp): serve distributed skills over MCP (SEP-2640)Β #2022): the expected text came fromread_text(), which turns a CRLF checkout into LF. The served text keeps CRLF. Compare to the decoded bytes.test_chatgpt_import_visits_each_mapping_key_once: the 15s hang guard timed out during startup on a loaded Windows runner. Raised to 60s.Test-only change.
π€ Generated with Claude Code
https://claude.ai/code/session_01CMYVL4TcbWdXhdvAzxfqjo