Exit the completion process on EOF#417
Merged
sadovnychyi merged 1 commit intoJun 18, 2019
Merged
Conversation
Coming from brennv@44e24b1 " Exit the completion process on EOF The real problem is that `BufferedProcess.kill` is *asynchronous* on Windows and Atom exits before it gets a chance to complete. So the process is left alive, and it ignores EOF and just keeps trying to read in an infinite loop. " Fixes #310 And probably #301
Member
|
Thanks. I'm currently traveling so please give me some extra time to push a new release with this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming from brennv@44e24b1
"
Exit the completion process on EOF
The real problem is that
BufferedProcess.killis asynchronous onWindows and Atom exits before it gets a chance to complete. So the
process is left alive, and it ignores EOF and just keeps trying to read
in an infinite loop.
"
Fixes #310
And probably #301