Repository navigation
Skip irrelevant calls in pathlib and comprehension rules - #30036
Open
MichaReiser wants to merge 2 commits into
Open
MichaReiser wants to merge 2 commits into
MichaReiser wants to merge 2 commits into
Conversation
MichaReiser
temporarily deployed
to
automations
November 4, 2026 13:30 — with 
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/lint-call-shape-checks
branch
from
November 4, 2026 17:57
52a5575 to
a030264
Compare
MichaReiser
temporarily deployed
to
automations
November 4, 2026 17:58 — with
GitHub Actions
Inactive
Contributor
|
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PTH123 checks whether a call resolves to
openbefore looking upfile,closefd, oropener. Eight comprehension rules share a check for the constructor name and the kind of its single positional argument, so calls such aslen(values)skip those rules entirely.Test Plan
The Ruff linter test suite passes, and the boxed and flat builds produce the same diagnostics and fixes on the rule fixtures.