Repository navigation
Store mapping pattern entries and captures in source order - #29889
Draft
MichaReiser wants to merge 1 commit into
Draft
MichaReiser wants to merge 1 commit into
MichaReiser wants to merge 1 commit into
Conversation
MichaReiser
temporarily deployed
to
automations
November 1, 2026 20:12 — with 
GitHub Actions
Inactive
Contributor
Typing conformance resultsNo changes detected ✅Current numbersThe percentage of diagnostics emitted that were expected errors held steady at 98.60%. The percentage of expected errors that received a diagnostic held steady at 98.86%. The number of fully passing files held steady at 137/146. Results for 3c2225d · Workflow run |
Contributor
Memory usage reportMemory usage unchanged ✅ Results for 3c2225d · Workflow run |
Contributor
|
Contributor
|
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 2, 2026 10:52
0363709 to
8bf7e54
Compare
MichaReiser
temporarily deployed
to
automations
November 2, 2026 10:52 — with
GitHub Actions
Inactive
Merging this PR will not alter performance
Comparing 
Footnotes
|
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 2, 2026 11:30
8bf7e54 to
1b416e6
Compare
MichaReiser
temporarily deployed
to
automations
November 2, 2026 11:31 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 2, 2026 13:48
1b416e6 to
ae3af64
Compare
MichaReiser
temporarily deployed
to
automations
November 2, 2026 13:49 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 2, 2026 13:56
ae3af64 to
1f4ded9
Compare
MichaReiser
had a problem deploying
to
automations
November 2, 2026 13:58 — with
GitHub Actions
Error
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 2, 2026 14:05
1f4ded9 to
44451d2
Compare
MichaReiser
temporarily deployed
to
automations
November 2, 2026 14:06 — with
GitHub Actions
Inactive
MichaReiser
temporarily deployed
to
automations
November 2, 2026 16:23 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 2, 2026 16:32
19fc665 to
c659764
Compare
MichaReiser
temporarily deployed
to
automations
November 2, 2026 16:35 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 2, 2026 17:27
c659764 to
fa3337b
Compare
MichaReiser
temporarily deployed
to
automations
November 2, 2026 17:28 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 2, 2026 18:37
fa3337b to
503f8a4
Compare
MichaReiser
temporarily deployed
to
automations
November 2, 2026 18:39 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 3, 2026 15:33
503f8a4 to
3388804
Compare
MichaReiser
temporarily deployed
to
automations
November 3, 2026 15:33 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 3, 2026 16:14
3388804 to
48b7491
Compare
MichaReiser
temporarily deployed
to
automations
November 3, 2026 16:15 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 4, 2026 11:59
48b7491 to
475a836
Compare
MichaReiser
temporarily deployed
to
automations
November 4, 2026 12:00 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 4, 2026 13:30
475a836 to
0f8d2da
Compare
MichaReiser
temporarily deployed
to
automations
November 4, 2026 13:30 — with
GitHub Actions
Inactive
MichaReiser
force-pushed
the
micha/boxed-mapping-pattern-items
branch
from
November 4, 2026 17:57
0f8d2da to
3c2225d
Compare
MichaReiser
temporarily deployed
to
automations
November 4, 2026 17:59 — with
GitHub Actions
Inactive
This branch was previously deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Store each mapping-pattern key with its pattern and keep
**namecaptures in the same sequence. A source-order visitor can then read the sequence directly. For recovered syntax such ascase {**first, "x": value, **last}:, the AST retains both captures where they appeared. Consumers that ask for the rest capture continue to get the last one.The parser, formatter, code generator, and ty read this representation from the boxed AST. On a file with 1,024 mapping patterns, each with two entries and a capture, the change reduced parsing from 10,312,958 to 10,156,245 instructions (−1.52%) and the source-order walk from 415,019 to 351,531 (−15.30%). Retained syntax fell from 829,880 to 813,496 bytes (−1.97%).
These measurements predate the comparison optimizations in #30033.
The five standard parser fixtures contain no mapping patterns. Their retained syntax size was unchanged, and the three paired parser measurements ranged from −0.04% to +0.03%. The CLI comparisons produced identical output.
Test Plan
Parser and source-order tests cover valid mappings, misplaced captures, and repeated captures. The updated parser snapshots preserve the existing source ranges and diagnostics. The formatter fixtures, linter tests, ty IDE tests, and ty mdtests passed.