Issue workflow progress
Progress of the issue based on the
Contributor Workflow
Make sure to fork this template and run yarn generate in the terminal.
Please make sure Mesh package versions under package.json matches yours.
Describe the bug
There is no way to pass a deepObject with a GET-parameter format that PHP recognizes.
loadOpenAPISubgraph takes a queryStringOptions object but that is ignored in loaders/json-schema addExecutionDirectivesToComposer by falling back to undefined when no operation-specific option has been provided:
queryStringOptions:
'queryStringOptions' in operationConfig
? operationConfig.queryStringOptions
: undefined,
Instead we should fallback to the queryStringOptions that is passed in:
queryStringOptions:
'queryStringOptions' in operationConfig
? operationConfig.queryStringOptions
: queryStringOptions,
To Reproduce Steps to reproduce the behavior:
This config does not change the behaviour:
export const composeConfig = defineComposeConfig({
output: 'supergraph.ts',
subgraphs: [
{
sourceHandler: loadOpenAPISubgraph('User', {
...
queryStringOptions : { arrayFormat: 'brackets' }
})
},
Expected behavior
Config should be respected
Environment:
Additional context
Fix:
packages/loaders/json-schema/src/addExecutionLogicToComposer.ts
Issue workflow progress
Progress of the issue based on the
Contributor Workflow
Github,
Stackblitz
or
CodeSandbox
Describe the bug
There is no way to pass a deepObject with a GET-parameter format that PHP recognizes.
loadOpenAPISubgraph takes a queryStringOptions object but that is ignored in loaders/json-schema addExecutionDirectivesToComposer by falling back to undefined when no operation-specific option has been provided:
Instead we should fallback to the queryStringOptions that is passed in:
To Reproduce Steps to reproduce the behavior:
Expected behavior
Config should be respected
Environment:
Additional context
Fix:
packages/loaders/json-schema/src/addExecutionLogicToComposer.ts