Skip to content

Update19 - #483

Merged
Jefiozie merged 11 commits into
mainfrom
update19
Feb 1, 2025
Merged

Jefiozie merged 11 commits into
mainfrom
update19

Conversation

@Jefiozie

@Jefiozie Jefiozie commented Dec 5, 2024

Copy link
Copy Markdown
Contributor

No description provided.

@Jefiozie

Copy link
Copy Markdown
Contributor Author

@Harpush @SanderElias if you could review this.

@Harpush

Harpush commented Dec 22, 2024

Copy link
Copy Markdown
Collaborator

Why did you remove angular split module? I think it should either stay or an array const should be exported.
Sometimes it is easier to just import all related components and directives instead of one by one.
What do you think? I am pretty sure const array spread import was fixed so I think it will work without modules.

@Jefiozie

Copy link
Copy Markdown
Contributor Author

I thought about as it is not really needed anymore because of the arrays. But I think I've seen still a issue open. Before I will push out the official 19 version I will investigate it

@Jefiozie

Jefiozie commented Jan 5, 2025

Copy link
Copy Markdown
Contributor Author

@Harpush Ive readded the module, I think it is good to leave it for now as this is easier for consumers. If the angular teams takes a different approach in modules we always can remove it.

@Harpush

Harpush commented Jan 18, 2025

Copy link
Copy Markdown
Collaborator

Can be in another PR - but with v19 we can drop mirrorSignal and use linkedSignal

@SupremeVoid

Copy link
Copy Markdown

Any update on this?
The current version causes warnings in angular 19 apps because of the old signals implementation.
8zpNZELhw1

@Jefiozie
Jefiozie enabled auto-merge (squash) February 1, 2025 08:50
@Jefiozie
Jefiozie merged commit 222ebcf into main Feb 1, 2025
@Jefiozie
Jefiozie deleted the update19 branch February 1, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants