You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
There are no guidelines to set up the repo for contributors, thus I took these steps:
git clone
npm ci - This will not work for Windows users npm i is required
ran npm run test_live
a. This crashed on rollup error. It the hint I got note to delete package-lock.json and node_modules use npm i instead of npm ci.
npm i
ng serve is throwing bunch of errors caused by Cannot find module 'angular-split' or its corresponding type declarations.ts(2307)
To Reproduce
Take my steps above, ideally on a Windows machine, the rollup will probably be caused only on Windows, but the missing module should be universal
If you are on Windows, use WSL to check out the repo, do the npm ci, and build in there. All our tools are geared towards working seamlessly with GitHub Actions.
All things you have observed (also in the PR) point towards not running inside of WSL ;)
Let's add a contributors guide explaining this a little bit more.
(as a side-note, when it works when you delete the package-lock, that is a local solution to you, just make sure you don't commit the changed package-lock file, as that would probably include Windows things and will break the GitHub action. )
@SanderElias I know enought not to post new package-lock when I previously deleted it :D but you have to be cautious.
I am actually not using WSL at all, that is probably where the problem comes from! However the solution to update reinstall without package-lock is actually fully working for native Windows users too!
I think adding notes about WSL requirement and a note about the native windows workaround should be enough for most people :)
Activity
Harpush commentedon May 17, 2025
For running you can use either:
npm run startOr two terminals (first 1 then 2):
ng build angular-split --watchng serveAnyway I will create a PR to fix the windows failures
Akxe commentedon May 17, 2025
Thanks, also if you would update the docs with the two commands than needs to be ran, it would be great
Harpush commentedon May 17, 2025
@Akxe can you first try my branch and make sure everything works for you on windows?
SanderElias commentedon May 19, 2025
Hi @Akxe,
Welcome to the club!
If you are on Windows, use WSL to check out the repo, do the
npm ci, and build in there. All our tools are geared towards working seamlessly with GitHub Actions.All things you have observed (also in the PR) point towards not running inside of WSL ;)
@Jefiozie, You are on Windows, too, right?
Let's add a contributors guide explaining this a little bit more.
(as a side-note, when it works when you delete the
package-lock, that is a local solution to you, just make sure you don't commit the changedpackage-lockfile, as that would probably include Windows things and will break the GitHub action. )Akxe commentedon May 19, 2025
@SanderElias I know enought not to post new
package-lockwhen I previously deleted it :D but you have to be cautious.I am actually not using WSL at all, that is probably where the problem comes from! However the solution to update reinstall without
package-lockis actually fully working for native Windows users too!I think adding notes about WSL requirement and a note about the native windows workaround should be enough for most people :)
SanderElias commentedon May 19, 2025
@Akxe would that PR be enough?