Skip to content

Unable to run tests after cloning #508

Closed

Description

@Akxe

Describe the bug
There are no guidelines to set up the repo for contributors, thus I took these steps:

  1. git clone
  2. npm ci - This will not work for Windows users npm i is required
  3. ran npm run test_live
    a. This crashed on rollup error. It the hint I got note to delete package-lock.json and node_modules use npm i instead of npm ci.
  4. npm i
  5. ng serve is throwing bunch of errors caused by Cannot find module 'angular-split' or its corresponding type declarations.ts(2307)

To Reproduce
Take my steps above, ideally on a Windows machine, the rollup will probably be caused only on Windows, but the missing module should be universal

Activity

  1. Harpush commented on May 17, 2025

    @Harpush
    Collaborator

    For running you can use either:
    npm run start

    Or two terminals (first 1 then 2):

    1. ng build angular-split --watch
    2. ng serve

    Anyway I will create a PR to fix the windows failures

  2. Akxe commented on May 17, 2025

    @Akxe
    ContributorAuthor

    Thanks, also if you would update the docs with the two commands than needs to be ran, it would be great

  3. Harpush commented on May 17, 2025

    @Harpush
    Collaborator

    @Akxe can you first try my branch and make sure everything works for you on windows?

  4. SanderElias commented on May 19, 2025

    @SanderElias
    Contributor

    Hi @Akxe,

    Welcome to the club!

    If you are on Windows, use WSL to check out the repo, do the npm ci, and build in there. All our tools are geared towards working seamlessly with GitHub Actions.

    All things you have observed (also in the PR) point towards not running inside of WSL ;)

    @Jefiozie, You are on Windows, too, right?

    Let's add a contributors guide explaining this a little bit more.

    (as a side-note, when it works when you delete the package-lock, that is a local solution to you, just make sure you don't commit the changed package-lock file, as that would probably include Windows things and will break the GitHub action. )

  5. Akxe commented on May 19, 2025

    @Akxe
    ContributorAuthor

    @SanderElias I know enought not to post new package-lock when I previously deleted it :D but you have to be cautious.

    I am actually not using WSL at all, that is probably where the problem comes from! However the solution to update reinstall without package-lock is actually fully working for native Windows users too!

    I think adding notes about WSL requirement and a note about the native windows workaround should be enough for most people :)

  6. SanderElias commented on May 19, 2025

    @SanderElias
    Contributor

    @Akxe would that PR be enough?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions