Skip to content

Splitter not compatible with Angular 19 #480

Closed

Description

@RobertDr

The build of my app using angular-split fails with this error message:
./node_modules/angular-split/fesm2022/angular-split.mjs:1092:13-35 - Error: export 'ɵɵStandaloneFeature' (imported as 'i0') was not found in '@angular/core' (possible exports: ...

It seems, that the new Angular version does not export "ɵɵStandaloneFeature" any more.

Activity

  1. RobertDr commented on Dec 4, 2024

    @RobertDr
    Author

    Does anyone else have the same problem and possibly found a workaround?

  2. BrianMikinski commented on Dec 7, 2024

    @BrianMikinski

    This is holding me up as well. Would like to upgrade as soon as possible

  3. RobertDr commented on Dec 19, 2024

    @RobertDr
    Author

    There is already a pull request Update19 for a migration to Angular 19. Unfortunately this PR was declined due to failed tests.

  4. Jefiozie commented on Dec 19, 2024

    @Jefiozie
    Contributor

    We are working on releasing it as soon as possible. The PR is updated and we will try to do our best to release it soon.

  5. Jefiozie commented on Dec 22, 2024

    @Jefiozie
    Contributor

    I've pushed out a beta release of 19: https://www.npmjs.com/package/angular-split/v/19.0.0-beta.0
    Please let me know if this fixes your issues. I'm aware the module is gone and I'm not sure if this is a good or bad practices. Let me know if this is working or not

  6. RobertDr commented on Dec 26, 2024

    @RobertDr
    Author

    My issues seems to be fixed with this beta release after some short tests.
    I will proceed with additional tests, when I'm back at work on January 2nd.
    But I don't expect additional problems, so I assume, this build may leave the beta state.
    Thank you very much!

  7. Jefiozie commented on Dec 26, 2024

    @Jefiozie
    Contributor

    @RobertDr thanks for providing me your feedback. I hope we can release it in the first weeks of January if nothing comes up in between or somebody reports a big bug

  8. RobertDr commented on Jan 3, 2025

    @RobertDr
    Author

    Just to confirm: after more tests, I still can't find a functional problem with my solution. I'm looking forward to the final release.
    Again: thank you very much!

  9. RobertDr commented on Jan 3, 2025

    @RobertDr
    Author

    Additional info: I get a deprecation warning in the browser console for each SplitComponent:

    The 'allowSignalWrites' flag is deprecated and no longer impacts effect() (writes are always allowed)
    SplitComponent | @ | angular-split.mjs:435
    -- | SplitComponent_Factory | @ | angular-split.mjs:734

    image

  10. Harpush commented on Jan 3, 2025

    @Harpush
    Collaborator

    We should remove this flag in v19.
    But anyway there is a draft PR that should discard the signal writing effect altogether: #455

  11. MaximeKoitsalu commented on Jan 16, 2025

    @MaximeKoitsalu

    Additional info: I get a deprecation warning in the browser console for each SplitComponent:

    The 'allowSignalWrites' flag is deprecated and no longer impacts effect() (writes are always allowed) SplitComponent | @ | angular-split.mjs:435 -- | SplitComponent_Factory | @ | angular-split.mjs:734

    image

    Experiencing the same with "angular-split": "^19.0.0-beta.2",

  12. Jefiozie commented on Jan 22, 2025

    @Jefiozie
    Contributor

    Hi @MaximeKoitsalu , just to confirm, you still see the warning in the latest beta release? The deprecation is correct there was q problem in our release cycle. We pushed a old version under a new tag.

  13. MaximeKoitsalu commented on Jan 22, 2025

    @MaximeKoitsalu

    Hi @Jefiozie , my experience is that the split component still functions but I still see the warnings in my console. The stack trace points to:

    <as-split [direction]="node.direction" [id]="node.id" gutterSize="4" unit="percent">

    Image

  14. RobertDr commented on Jan 22, 2025

    @RobertDr
    Author

    Yes, I still see this warning in the "19.0.0-beta.2" release.

    It could be an important additional information, that these warnings are conly reported, when I'm running my development build using "ng serve", not when I'm running the production build using "ng build" (and hosted via IIS).

  15. Jefiozie commented on Feb 1, 2025

    @Jefiozie
    Contributor

    I'm closing this issues as we just released a version 19. Feel free to reopen issues that are related to that version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions