Repository navigation
Conversation
JeanMeche
requested review from
crisbeto and
mattrbeck
and removed request for
crisbeto
October 12, 2026 15:55
JeanMeche
marked this pull request as ready for review
October 12, 2026 15:55
Member
|
Looks like this needs another rebase. |
Add synchronous execution paths to WasmAnalyzer, HybridCompiler, and processor so synchronous compiler test harnesses can invoke the WASM analyzer and preprocessor without async bridging.
Introduce performNgpCompilationSync, createNgpBoundTemplate, createNgpTestCompiler, MockFileSystem-to-WasmHostFs bridging, and output AST normalization so compiler-cli test suites can execute against NGP when NG_COMPILER_BACKEND=ngp.
…t helper Register a Jasmine SpecFilter in runInEachFileSystem that marks known NGP compiler gap specs as pending (xit) by default in NG_COMPILER_BACKEND=ngp mode (unless NGP_RUN_KNOWN_FAILURES=1 is set).
Wire NgtscTestEnvironment to execute compilations and diagnostics through NGP when NG_COMPILER_BACKEND=ngp is set, and add the //packages/compiler-cli/test/ngtsc:ngtsc_ngp Bazel test target.
Support NGP compilation and output normalization in the compliance test harness and add the full_ngp and local_ngp Bazel test targets.
…t NGP Normalize declaration-only .d.ts output in NGP test mode and add the declaration-only_ngp Bazel test target.
Verify preprocessed NGP .ng.ts output across all compliance test cases via ts.getPreEmitDiagnostics and add the codegen_ngp Bazel test target.
Delegate diagnose() in the template typecheck test helper to NGP when NG_COMPILER_BACKEND=ngp is set, and add the //packages/compiler-cli/src/ngtsc/typecheck/test:test_ngp Bazel test target.
Add test_ngp Bazel test targets across all 16 extended template check test suites under packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks.
Delegate getBoundTemplate() in the template indexer test helper to NGP's HybridCompiler and IndexerBoundTemplate in NG_COMPILER_BACKEND=ngp mode, and add the //packages/compiler-cli/src/ngtsc/indexer/test:test_ngp Bazel test target.
Wire makeFreshCompiler() in compiler_spec.ts to createNgpTestCompiler in NG_COMPILER_BACKEND=ngp mode, and add the //packages/compiler-cli/src/ngtsc/core/test:test_ngp Bazel test target.
JeanMeche
force-pushed
the
ngp-shared-compiler-tests
branch
from
October 12, 2026 21:23
4bcc42e to
eb3d99b
Compare
crisbeto
approved these changes
Oct 13, 2026
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…ngular#71313) Introduce performNgpCompilationSync, createNgpBoundTemplate, createNgpTestCompiler, MockFileSystem-to-WasmHostFs bridging, and output AST normalization so compiler-cli test suites can execute against NGP when NG_COMPILER_BACKEND=ngp. PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…t helper (angular#71313) Register a Jasmine SpecFilter in runInEachFileSystem that marks known NGP compiler gap specs as pending (xit) by default in NG_COMPILER_BACKEND=ngp mode (unless NGP_RUN_KNOWN_FAILURES=1 is set). PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
Wire NgtscTestEnvironment to execute compilations and diagnostics through NGP when NG_COMPILER_BACKEND=ngp is set, and add the //packages/compiler-cli/test/ngtsc:ngtsc_ngp Bazel test target. PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…1313) Support NGP compilation and output normalization in the compliance test harness and add the full_ngp and local_ngp Bazel test targets. PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…t NGP (angular#71313) Normalize declaration-only .d.ts output in NGP test mode and add the declaration-only_ngp Bazel test target. PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…gular#71313) Verify preprocessed NGP .ng.ts output across all compliance test cases via ts.getPreEmitDiagnostics and add the codegen_ngp Bazel test target. PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…gular#71313) Delegate diagnose() in the template typecheck test helper to NGP when NG_COMPILER_BACKEND=ngp is set, and add the //packages/compiler-cli/src/ngtsc/typecheck/test:test_ngp Bazel test target. PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…GP (angular#71313) Add test_ngp Bazel test targets across all 16 extended template check test suites under packages/compiler-cli/src/ngtsc/typecheck/extended/test/checks. PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…lar#71313) Delegate getBoundTemplate() in the template indexer test helper to NGP's HybridCompiler and IndexerBoundTemplate in NG_COMPILER_BACKEND=ngp mode, and add the //packages/compiler-cli/src/ngtsc/indexer/test:test_ngp Bazel test target. PR Close angular#71313
crisbeto
pushed a commit
to crisbeto/angular
that referenced
this pull request
Oct 13, 2026
…ar#71313) Wire makeFreshCompiler() in compiler_spec.ts to createNgpTestCompiler in NG_COMPILER_BACKEND=ngp mode, and add the //packages/compiler-cli/src/ngtsc/core/test:test_ngp Bazel test target. PR Close angular#71313
|
This pull request has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change will help us highlight the remaining gaps in the implementation by running a set of our compiler tests against NGP.
See individual commits