Skip to content

docs: add clear buttons inside autocomplete examples#68873

Open
tjshiu wants to merge 2 commits into
angular:mainfrom
tjshiu:combo-delete
Open

docs: add clear buttons inside autocomplete examples#68873
tjshiu wants to merge 2 commits into
angular:mainfrom
tjshiu:combo-delete

Conversation

@tjshiu
Copy link
Copy Markdown
Contributor

@tjshiu tjshiu commented May 21, 2026

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

Updates autocomplete examples to have a clear button so that we can clear auto-select examples.

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Documentation content changes
  • angular.dev application / infrastructure changes
  • Other... Please describe:

What is the current behavior?

Missing clear button

Issue Number: N/A

What is the new behavior?

Adds clear button feature to autocomplete examples

Does this PR introduce a breaking change?

  • Yes
  • No

Other information

@angular-robot angular-robot Bot added the area: docs Related to the documentation label May 21, 2026
@tjshiu tjshiu added action: review The PR is still awaiting reviews from at least one requested reviewer target: rc This PR is targeted for the next release-candidate adev: preview labels May 21, 2026
@ngbot ngbot Bot added this to the Backlog milestone May 21, 2026
@tjshiu tjshiu requested review from JeanMeche, bencodezen and ok7sai May 21, 2026 22:35
SkyZeroZx
SkyZeroZx reviewed May 21, 2026
View reviewed changes
Comment thread adev/src/content/examples/aria/autocomplete/src/basic/app/app.html Outdated
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 21, 2026 •
edited
Loading

Deployed adev-preview for 7312ad3 to: https://ng-dev-previews-fw--pr-angular-angular-68873-adev-prev-gu50dojh.web.app

Note: As new commits are pushed to this pull request, this link is updated after the preview is rebuilt.

ok7sai
ok7sai approved these changes May 21, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@ok7sai ok7sai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Comment thread adev/src/content/examples/aria/autocomplete/src/basic/app/app.html Outdated
@tjshiu tjshiu marked this pull request as ready for review May 22, 2026 00:30
@tjshiu tjshiu added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels May 22, 2026
@tjshiu tjshiu removed the request for review from bencodezen May 22, 2026 18:23
@tjshiu
Copy link
Copy Markdown
Contributor Author

tjshiu commented May 23, 2026

@alxhub The mergeability check on this PR is currently failing for 22.0.x because the autocomplete modernization commit f84653605a65e9abd8f5db2fd2c41797fe89e62a is currently only on main and hasn't been backported to the 22.0.x branch yet.

Can you help and cherry-pick that commit into the 22.0.x branch? Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JeanMeche JeanMeche JeanMeche approved these changes

@ok7sai ok7sai ok7sai approved these changes

+1 more reviewer

@SkyZeroZx SkyZeroZx SkyZeroZx left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker adev: preview area: docs Related to the documentation target: rc This PR is targeted for the next release-candidate

Projects

None yet

Milestone

Backlog

Development

Successfully merging this pull request may close these issues.

4 participants

@tjshiu @JeanMeche @SkyZeroZx @ok7sai