fix(devtools): handle null-prototype object previews#68869
Closed
puneetdixit200 wants to merge 1 commit into
Closed
fix(devtools): handle null-prototype object previews#68869puneetdixit200 wants to merge 1 commit into
puneetdixit200 wants to merge 1 commit into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Guard DevTools serializer previews against objects without a constructor and use Object.prototype.hasOwnProperty.call when expanding selected nested properties. This keeps Object.groupBy and Object.create(null) values inspectable instead of throwing while rendering component state. Fixes angular#68798
c06179a to
5cf07de
Compare
Member
|
Superseeded by #68879 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #68798
Angular DevTools can throw while previewing component state values created with
Object.create(null)orObject.groupBy(), because the serializer assumes object values always have a constructor. Expanding selected nested properties also assumeshasOwnPropertyexists on the object itself.What is the new behavior?
Null-prototype objects are previewed as plain objects, and selected nested properties are checked with
Object.prototype.hasOwnProperty.call. The DevTools state serializer can inspect those values without throwing.Does this PR introduce a breaking change?
Other information
Local checks:
./node_modules/.bin/prettier --check devtools/projects/ng-devtools-backend/src/lib/state-serializer/object-utils.ts devtools/projects/ng-devtools-backend/src/lib/state-serializer/serialized-descriptor-factory.ts devtools/projects/ng-devtools-backend/src/lib/state-serializer/state-serializer.spec.tsgit diff --check./node_modules/.bin/bazelisk --output_user_root="$PWD/.bazel-user-root" test -- //devtools/projects/ng-devtools-backend/src/lib/state-serializer:test