fix(vscode-extension): prompt for confirmation before loading workspa…#68864
Merged
Conversation
…ce tsdk Harden the typescript.tsdk and js/ts.tsdk.path settings loading in the VS Code extension client. This change hardens tsdk loading by: 1. Ignoring workspace-level tsdk paths in untrusted workspaces. 2. Prompting the user for explicit confirmation before loading a workspace-level tsdk path in trusted workspaces, and saving the approval state in a secure, local workspaceState.
alan-agius4
approved these changes
May 22, 2026
Member
|
This PR was merged into the repository. The changes were merged into the following branches:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ce tsdk
Harden the typescript.tsdk and js/ts.tsdk.path settings loading in the VS Code extension client.
This change hardens tsdk loading by: