refactor(devtools): remove unnecessary async from serializeTransferState#68854
Open
bravesasha wants to merge 1 commit into
Open
refactor(devtools): remove unnecessary async from serializeTransferState#68854bravesasha wants to merge 1 commit into
bravesasha wants to merge 1 commit into
Conversation
erkamyaman
reviewed
May 21, 2026
Contributor
erkamyaman
left a comment
There was a problem hiding this comment.
I believe your commit message should have a scope and also you should also add a commit body.
See: https://github.com/angular/angular/blob/main/contributing-docs/commit-message-guidelines.md
Remove unnecessary `async`/`Promise<void>` from `serializeTransferState` and the redundant `async () =>` wrapper in `provideAppInitializer` — the function contains no async operations, so this is a zero behavior change cleanup.
JeanMeche
approved these changes
May 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove unnecessary
async/Promise<void>fromserializeTransferStateand the redundantasync () =>wrapper inprovideAppInitializerthe function contains no async operations, so this is a zero behavior change cleanup.