docs(forms): remove experimental framing from Signal Forms PACKAGE.md#68769
Closed
LeSingh1 wants to merge 2 commits into
Closed
docs(forms): remove experimental framing from Signal Forms PACKAGE.md#68769LeSingh1 wants to merge 2 commits into
LeSingh1 wants to merge 2 commits into
Conversation
Following angular#68581 (which graduated Signal Forms APIs to public API) and angular#68654 (which removed experimental warnings from Signal Forms docs across adev), `packages/forms/signals/PACKAGE.md` still: * titled the API `🚧 Experimental Signal-Based Forms API 🏗️`; * described it as something used "to explore potential designs"; * listed `Interop with Reactive/Template forms`, `Strongly-typed binding to UI controls`, and `Debouncing validation` under "Not yet supported" — these are all shipped (see `packages/forms/signals/src/compat/`, `controls/interop_ng_control.ts`, `FormValueControl` / `FormCheckboxControl`, and `src/api/rules/debounce.ts`); * called the API "early and still highly experimental" in the FAQ. This change refreshes the page to reflect the graduated status. Items that I could not verify as shipped (`Dynamic objects`, `Tuples`) are kept under "Not yet supported". The parent `packages/forms/PACKAGE.md` still said you can build forms "in one of two ways"; updated to three to include signal forms. Closes angular#68724 Signed-off-by: LeSingh1 <sshaurya914@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Author
|
@googlebot I signed it! |
Signed-off-by: LeSingh1 <sshaurya914@gmail.com>
Member
|
Thanks for the suggestion, we'll update that document ourselves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
PR Type
Documentation content changes
What is the current behavior?
Following the merge of #68581 (which graduated the Signal Forms APIs to public API) and #68654 (which removed experimental warnings from Signal Forms docs across adev),
packages/forms/signals/PACKAGE.mdstill:# 🚧 Experimental Signal-Based Forms API 🏗️;Interop with Reactive/Template forms— seepackages/forms/signals/src/compat/andpackages/forms/signals/src/controls/interop_ng_control.tsStrongly-typed binding to UI controls—FormValueControl<T>andFormCheckboxControlare publicly exported (packages/forms/signals/src/directive/form_field.ts)Debouncing validation— seepackages/forms/signals/src/api/rules/debounce.tsPer the contributor comment on #68724, the parent
packages/forms/PACKAGE.mdalso still said you can build forms "in one of two ways" and listed only reactive + template-driven, when there are now three.What is the new behavior?
Refreshed
packages/forms/signals/PACKAGE.mdto drop the experimental framing and removed the three now-supported items from the "Not yet supported" list. KeptDynamic objectsandTuplessince I could not verify those have shipped. The "early and still highly experimental" line in the FAQ is replaced with a no-op (the rest of that paragraph already captures the intended sentiment about incremental rollout).Updated
packages/forms/PACKAGE.mdto say "three ways" and to introduce signal forms as the third option.Issue Number: #68724