refactor(core): avoid invoking IntersectionObserver in defer triggers on the server#52306
Closed
AndrewKushnir wants to merge 1 commit into
Closed
refactor(core): avoid invoking IntersectionObserver in defer triggers on the server#52306AndrewKushnir wants to merge 1 commit into
AndrewKushnir wants to merge 1 commit into
Conversation
… on the server This commit updates the logic to make sure that DOM-specific triggers do not produce errors on the server. Resolves angular#52304.
b2c12a0 to
7220e1e
Compare
crisbeto
approved these changes
Oct 21, 2023
Contributor
Author
Contributor
|
This PR was merged into the repository by commit 666853f. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ChellappanRajan
pushed a commit
to ChellappanRajan/angular
that referenced
this pull request
Jan 23, 2024
… on the server (angular#52306) This commit updates the logic to make sure that DOM-specific triggers do not produce errors on the server. Resolves angular#52304. PR Close angular#52306
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit updates the logic to make sure that DOM-specific triggers do not produce errors on the server.
Resolves #52304.
Does this PR introduce a breaking change?