Skip to content

Decreases support-annotation version to 22.0.0 to be able to compile …#24

Closed
vogella wants to merge 0 commit into
android:masterfrom
vogellacompany:master
Closed

Decreases support-annotation version to 22.0.0 to be able to compile …#24
vogella wants to merge 0 commit into
android:masterfrom
vogellacompany:master

Conversation

@vogella

@vogella vogella commented May 15, 2015

Copy link
Copy Markdown
Contributor

To compile the "BasisSample" with Gradle I had to adjust the version of the support-annotations to 22.0.0.

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@vogella

vogella commented May 15, 2015

Copy link
Copy Markdown
Contributor Author

I signed it!

On Fri, May 15, 2015 at 5:27 PM, googlebot notifications@github.com wrote:

Thanks for your pull request. It looks like this may be your first
contribution to a Google open source project, in which case you'll need to
sign a Contributor License Agreement (CLA).

[image: 📝] Please visit https://cla.developers.google.com/
https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll

verify. Thanks.


Reply to this email directly or view it on GitHub
#24 (comment)
.

Geschäftsführer

vogella GmbH

Haindaalwisch 17a, 22395 Hamburg
Amtsgericht Hamburg: HRB 127058
Geschäftsführer: Lars Vogel, Jennifer Nerlich de Vogel
USt-IdNr.: DE284122352
Fax (032) 221739404, Email: lars.vogel@vogella.com, Web:
http://www.vogella.com

Comment thread espresso/BasicSample/app/build.gradle Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Revert and add:
allprojects {
repositories {
jcenter()
}

configurations.all {
    resolutionStrategy.force 'com.android.support:support-annotations:22.1.0'
}

}

to espresso/BasicSample/build.gradle

Would be great if you could apply the same fix to all the individual samples which depend on support-annotations

@otw

otw commented May 15, 2015

Copy link
Copy Markdown
Contributor

I added a comment to your change on how to fix it. Basically the issue is the we force resolution for the top lvl build file but not for each sample. We didn't catch this regression on the build server because we always build from the root folder.

@vogella vogella closed this Jun 1, 2015
@vogella

vogella commented Jun 2, 2015

Copy link
Copy Markdown
Contributor Author

@otw Started to fix these issues with your advise. Please see #29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants