Skip to content

fix(acp): pass session working_dir to on_call_tool #10689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Abhijay007 wants to merge 1 commit into
base: main
Choose a base branch
from
+14 −1
Open

fix(acp): pass session working_dir to on_call_tool #10689

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(acp): pass session working_dir to on_call_tool 
ACP goose/call_tool was constructing ToolCallContext with working_dir:
None, so tools that require a session cwd (e.g. summarize) always failed
with "working_dir is required". Load the session and pass its working_dir,
matching the agent dispatch path.
  • Loading branch information
@Abhijay007
Abhijay007 committed Jul 25, 2026
commit e2a61db1855dd5628f1de76812ac632e0e69ab98
15 changes: 14 additions & 1 deletion crates/goose/src/acp/server/tools.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,20 @@ impl GooseAcpAgent {
params
};

let ctx = crate::agents::ToolCallContext::new(session_id.clone(), None, None);
let session = self
.session_manager
.get_session(session_id, false)
.await
.map_err(|_| {
agent_client_protocol::Error::resource_not_found(Some(session_id.to_string()))
.data(format!("Session not found: {}", session_id))
})?;

let ctx = crate::agents::ToolCallContext::new(
session_id.clone(),
Some(session.working_dir),
None,
);
let tool_result = agent
.extension_manager
.dispatch_tool_call(&ctx, tool_call, CancellationToken::new())
Expand Down