fix(acp): pass session working_dir to on_call_tool#10689
Open
Abhijay007 wants to merge 1 commit into
Open
Conversation
ACP goose/call_tool was constructing ToolCallContext with working_dir: None, so tools that require a session cwd (e.g. summarize) always failed with "working_dir is required". Load the session and pass its working_dir, matching the agent dispatch path.
|
I independently reproduced #10680 on the same base while this PR was being opened. This source fix addresses the exact dispatch gap, and I added a deterministic ACP regression that creates a real session cwd, calls the bundled Proof on this PR's exact head
The test-only signed commit is here: Baltsat/goose-b-nnett@1f93c3d Feel free to cherry-pick it into this branch; it only changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes : #10680
Summary
ACP goose/call_tool was constructing ToolCallContext with working_dir: None, so tools that require a session cwd (e.g. summarize) always failed with "working_dir is required". Load the session and pass its working_dir, matching the agent dispatch path.
Testing
manual